Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why not use React v.15 ref system? #38

Closed
himalayafan opened this issue Mar 9, 2016 · 4 comments
Closed

why not use React v.15 ref system? #38

himalayafan opened this issue Mar 9, 2016 · 4 comments

Comments

@himalayafan
Copy link

I notice you are using the old React v.0.13 for ref. Plans to update to support React v. 15?

@Lucifier129
Copy link
Owner

It's already support React v15.0-rc.1,

The comment at https://github.com/Lucifier129/react-lite/blob/master/src/virtual-dom.js#L399 means support the style of React v0.13, it does not mean use the old way for ref.

@himalayafan
Copy link
Author

Ok. I just noticed it because you are using getDOMNode. That is removed in React v15, and findDOMNode are now deprecated and will be removed soon.

You will remove getDOMNode ?

@Lucifier129
Copy link
Owner

Yeah, react-lite will remove getDOMNode soon;

@Lucifier129
Copy link
Owner

I change my decision, just keep the old api to support more feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants