Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort and reorder children like React 0.14 / 15 #41

Closed
himalayafan opened this issue Mar 10, 2016 · 3 comments
Closed

sort and reorder children like React 0.14 / 15 #41

himalayafan opened this issue Mar 10, 2016 · 3 comments

Comments

@himalayafan
Copy link

I noticed that many important features for dealing with children is not adopted into React lite. E.g. insertAt(), a function React uses for children.

Plan to implement it?

React now also uses optimizations for Edge, when they deal with children. Added in React 15. This is not included either.

And you are not removing text nodes on diff. If nodeA have text and nodeB doesn't. nodeB will get undefined as text. In react this node are removed and reordered.

So any plans for a proper children diff algorithm ?

@Lucifier129
Copy link
Owner

working on it.

@himalayafan
Copy link
Author

I noticed your latest changes, and was running the vdom bench. Seems like you dropped from 280 000 down till 220 000. So a little improvement.

But still one of the slowest libraries out there. What is your plan to get it down to 50 000 ?

@Lucifier129
Copy link
Owner

add reorder feature to react-lite at version 0.15.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants