A very Strange(unrelated) error message when build lucky app failed with component.

[zw963]

Following is a very oddness error message which i consider it useful to mention here, you can reproduce it use following sample app strange_error branch.

https://github.com/one-in-ten-thousand/production_line_report/tree/strange_error

Basically, i just want to use a component for common purpose, this is source code.

as you can see, it just a each loop on records, with, pass the different part into it.

class RecordList < BaseComponent
  needs records : ManufactoryQuery | WorkshopQuery
  needs show : Admin::Manufactories::Show.class | Admin::Workshops::Show.class
  needs edit : Admin::Manufactories::Edit.class | Admin::Workshops::Edit.class
  needs delete : Admin::Manufactories::Delete.class | Admin::Workshops::Delete.class

Strange things start happen here,

I use it like this in two different page.

class Admin::Manufactories::IndexPage < MainLayout
  needs manufactories : ManufactoryQuery
  
  def content
    mount RecordList,
      records: manufactories, # <= passed manufactories Here
      show: Show,
      edit: Edit,
      delete: Delete
  end
end

class Admin::Manufactories::ShowPage < MainLayout
  needs workshops : WorkshopQuery

  def content
    mount RecordList,
      records: workshops, # <= passed workshops Here.
      show: ::Admin::Workshops::Show,
      edit: ::Admin::Workshops::Edit,
      delete: ::Admin::Workshops::Delete
  end
end

When i try to build on it, i get following error message.

error trace, click to open

 ╰─ $ 1  shards build --error-trace
Dependencies are satisfied
Building: app
Error target app failed to compile:
In src/production_line_report.cr:6:1

 6 | require "./start_server"
     ^
Error: while requiring "./start_server"


In src/start_server.cr:16:12

 16 | app_server.listen
                 ^-----
Error: instantiating 'AppServer#listen()'


In src/app_server.cr:24:12

 24 | server.listen(host, port, reuse_port: false)
             ^-----
Error: instantiating 'HTTP::Server#listen(String, Int32)'


In /home/zw963/Crystal/share/crystal/src/http/server.cr:443:5

 443 | listen
       ^-----
Error: instantiating 'listen()'


In /home/zw963/Crystal/share/crystal/src/http/server.cr:457:9

 457 | loop do
       ^---
Error: instantiating 'loop()'


In /home/zw963/Crystal/share/crystal/src/http/server.cr:457:9

 457 | loop do
       ^---
Error: instantiating 'loop()'


In /home/zw963/Crystal/share/crystal/src/http/server.cr:468:13

 468 | spawn handle_client(_io)
       ^
Error: expanding macro


There was a problem expanding macro 'spawn'

Called macro defined in /home/zw963/Crystal/share/crystal/src/concurrent.cr:99:1

 99 | macro spawn(call, *, name = nil, same_thread = false, &block)

Which expanded to:

 >  1 |   
 >  2 | 
 >  3 |   
 >  4 |     ->(
 >  5 |       
 >  6 |         __arg0 : typeof(_io),
 >  7 |       
 >  8 |       
 >  9 |       ) {
 > 10 |       spawn(name: nil, same_thread: false) do
 > 11 |         handle_client(
 > 12 |           
 > 13 |             __arg0,
 > 14 |           
 > 15 |           
 > 16 |         )
 > 17 |       end
 > 18 |       }.call(
 > 19 |         
 > 20 |           _io,
 > 21 |         
 > 22 |         
 > 23 |       )
 > 24 |   
Error: instantiating 'handle_client(IO+)'


In /home/zw963/Crystal/share/crystal/src/http/server.cr:515:16

 515 | @processor.process(io, io)
                  ^------
Error: instantiating 'HTTP::Server::RequestProcessor#process(IO+, IO+)'


In /home/zw963/Crystal/share/crystal/src/http/server/request_processor.cr:50:13

 50 | Log.with_context do
          ^-----------
Error: instantiating 'Log#with_context()'


In /home/zw963/Crystal/share/crystal/src/log/main.cr:119:16

 119 | self.class.with_context(**kwargs) do
                  ^-----------
Error: instantiating 'Log.class#with_context(NamedTuple())'


In /home/zw963/Crystal/share/crystal/src/log/main.cr:119:16

 119 | self.class.with_context(**kwargs) do
                  ^-----------
Error: instantiating 'Log.class#with_context(NamedTuple())'


In /home/zw963/Crystal/share/crystal/src/http/server/request_processor.cr:50:13

 50 | Log.with_context do
          ^-----------
Error: instantiating 'Log#with_context()'


In /home/zw963/Crystal/share/crystal/src/http/server/request_processor.cr:51:20

 51 | @handler.call(context)
               ^---
Error: instantiating '(HTTP::Handler | Proc(HTTP::Server::Context, Nil))#call(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handlers/compress_handler.cr:12:5

 12 | {% if flag?(:without_zlib) %}
      ^
Error: expanding macro


There was a problem expanding macro 'macro_140028586226336'

Called macro defined in /home/zw963/Crystal/share/crystal/src/http/server/handlers/compress_handler.cr:12:5

 12 | {% if flag?(:without_zlib) %}

Which expanded to:

 > 1 | 
 > 2 |       context.response.output = CompressIO.new(context.response.output, context)
 > 3 |       call_next(context)
 > 4 |     
Error: instantiating 'call_next(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handler.cr:28:20

 28 | next_handler.call(context)
                   ^---
Error: instantiating '(HTTP::Handler | Proc(HTTP::Server::Context, Nil))#call(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handlers/error_handler.cr:16:5

 16 | call_next(context)
      ^--------
Error: instantiating 'call_next(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handler.cr:28:20

 28 | next_handler.call(context)
                   ^---
Error: instantiating '(HTTP::Handler | Proc(HTTP::Server::Context, Nil))#call(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handlers/log_handler.cr:15:7

 15 | call_next(context)
      ^--------
Error: instantiating 'call_next(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handler.cr:28:20

 28 | next_handler.call(context)
                   ^---
Error: instantiating '(HTTP::Handler | Proc(HTTP::Server::Context, Nil))#call(HTTP::Server::Context)'


In lib/lucky/src/charms/static_file_handler.cr:5:5

 5 | super(context)
     ^----
Error: instantiating 'super(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handlers/static_file_handler.cr:34:9

 34 | call_next(context)
      ^--------
Error: instantiating 'call_next(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handler.cr:28:20

 28 | next_handler.call(context)
                   ^---
Error: instantiating '(HTTP::Handler | Proc(HTTP::Server::Context, Nil))#call(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handlers/static_file_handler.cr:34:9

 34 | call_next(context)
      ^--------
Error: instantiating 'call_next(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handler.cr:28:20

 28 | next_handler.call(context)
                   ^---
Error: instantiating '(HTTP::Handler | Proc(HTTP::Server::Context, Nil))#call(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handlers/websocket_handler.cr:23:14

 23 | return call_next context
             ^--------
Error: instantiating 'call_next(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handler.cr:28:20

 28 | next_handler.call(context)
                   ^---
Error: instantiating '(HTTP::Handler | Proc(HTTP::Server::Context, Nil))#call(HTTP::Server::Context)'


In lib/lucky/src/lucky/error_handler.cr:14:5

 14 | call_next(context)
      ^--------
Error: instantiating 'call_next(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handler.cr:28:20

 28 | next_handler.call(context)
                   ^---
Error: instantiating '(HTTP::Handler | Proc(HTTP::Server::Context, Nil))#call(HTTP::Server::Context)'


In lib/lucky/src/lucky/force_ssl_handler.cr:37:7

 37 | call_next(context)
      ^--------
Error: instantiating 'call_next(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handler.cr:28:20

 28 | next_handler.call(context)
                   ^---
Error: instantiating '(HTTP::Handler | Proc(HTTP::Server::Context, Nil))#call(HTTP::Server::Context)'


In lib/lucky/src/lucky/http_method_override_handler.cr:11:5

 11 | call_next(context)
      ^--------
Error: instantiating 'call_next(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handler.cr:28:20

 28 | next_handler.call(context)
                   ^---
Error: instantiating '(HTTP::Handler | Proc(HTTP::Server::Context, Nil))#call(HTTP::Server::Context)'


In lib/lucky/src/lucky/log_handler.cr:29:7

 29 | call_next(context)
      ^--------
Error: instantiating 'call_next(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handler.cr:28:20

 28 | next_handler.call(context)
                   ^---
Error: instantiating '(HTTP::Handler | Proc(HTTP::Server::Context, Nil))#call(HTTP::Server::Context)'


In lib/lucky/src/lucky/remote_ip_handler.cr:26:5

 26 | call_next(context)
      ^--------
Error: instantiating 'call_next(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handler.cr:28:20

 28 | next_handler.call(context)
                   ^---
Error: instantiating '(HTTP::Handler | Proc(HTTP::Server::Context, Nil))#call(HTTP::Server::Context)'


In lib/lucky/src/lucky/request_id_handler.cr:24:5

 24 | call_next(context)
      ^--------
Error: instantiating 'call_next(HTTP::Server::Context)'


In /home/zw963/Crystal/share/crystal/src/http/server/handler.cr:28:20

 28 | next_handler.call(context)
                   ^---
Error: instantiating '(HTTP::Handler | Proc(HTTP::Server::Context, Nil))#call(HTTP::Server::Context)'


In lib/lucky/src/lucky/route_handler.cr:10:52

 10 | handler.payload.new(context, handler.params).perform_action
                                                   ^-------------
Error: instantiating 'BrowserAction+#perform_action()'


In lib/lucky/src/lucky/renderable.cr:136:16

 136 | response = call
                  ^---
Error: instantiating 'call()'


There was a problem expanding macro 'setup_call_method'

Called macro defined in lib/lucky/src/lucky/routable.cr:89:3

 89 | macro setup_call_method(body)

Which expanded to:

 >  1 |     def call
 >  2 |       # Ensure clients_desired_format is cached by calling it
 >  3 |       clients_desired_format
 >  4 | 
 >  5 |       __temp_260 = run_before_pipes
 >  6 | 
 >  7 |       __temp_261 = if __temp_260.is_a?(Lucky::Response)
 >  8 |         __temp_260
 >  9 |       else
 > 10 |         begin
 > 11 |   manufactory = ManufactoryQuery.find(manufactory_id)
 > 12 |   workshops = WorkshopQuery.new.manufactory_id(manufactory_id)
 > 13 |   html(ShowPage, manufactory: manufactory, workshops: workshops)
 > 14 | end
 > 15 |       end
 > 16 | 
 > 17 |       __temp_260 = run_after_pipes
 > 18 | 
 > 19 |       if __temp_260.is_a?(Lucky::Response)
 > 20 |         __temp_260
 > 21 |       else
 > 22 |         __temp_261
 > 23 |       end
 > 24 |     end
 > 25 |   
Error: expanding macro


There was a problem expanding macro 'html'

Called macro defined in lib/lucky/src/lucky/renderable.cr:46:3

 46 | macro html(page_class = nil, _with_status_code = 200, **assigns)

Which expanded to:

 >  1 |     
 >  2 |     validate_page_class!(ShowPage)
 >  3 | 
 >  4 |     # Found in Admin::Manufactories::Show
 >  5 |     view = ShowPage.new(
 >  6 |       context: context,
 >  7 |       
 >  8 |         manufactory: manufactory,
 >  9 |       
 > 10 |         workshops: workshops,
 > 11 |       
 > 12 |       
 > 13 |         current_user: current_user,
 > 14 |       
 > 15 |     )
 > 16 |     Lucky::TextResponse.new(
 > 17 |       context,
 > 18 |       html_content_type,
 > 19 |       view.perform_render,
 > 20 |       status: 200,
 > 21 |       debug_message: log_message(view),
 > 22 |       enable_cookies: enable_cookies?
 > 23 |     )
 > 24 |   
Error: instantiating 'Admin::Manufactories::ShowPage#perform_render()'


In lib/lucky/src/lucky/html_builder.cr:29:5

 29 | render
      ^-----
Error: instantiating 'render()'


In src/pages/main_layout.cr:22:5

 22 | html lang: "en" do
      ^---
Error: instantiating 'html()'


In src/pages/main_layout.cr:22:5

 22 | html lang: "en" do
      ^---
Error: instantiating 'html()'


In src/pages/main_layout.cr:25:7

 25 | body do
      ^---
Error: instantiating 'body()'


In src/pages/main_layout.cr:25:7

 25 | body do
      ^---
Error: instantiating 'body()'


In src/pages/main_layout.cr:28:9

 28 | content
      ^------
Error: instantiating 'content()'


In src/pages/admin/manufactories/show_page.cr:11:5

 11 | mount RecordList,
      ^----
Error: instantiating 'mount(RecordList.class)'


In lib/lucky/src/lucky/mount_component.cr:13:5

 13 | print_component_comment(component) do
      ^----------------------
Error: instantiating 'print_component_comment(RecordList.class)'


In lib/lucky/src/lucky/mount_component.cr:13:5

 13 | print_component_comment(component) do
      ^----------------------
Error: instantiating 'print_component_comment(RecordList.class)'


In lib/lucky/src/lucky/mount_component.cr:14:71

 14 | component.new(*args, **named_args).view(view).context(@context).render
                                                                      ^-----
Error: instantiating 'RecordList#render()'


In src/components/records_list.cr:8:5

 8 | table class: "highlight centered" do
     ^----
Error: instantiating 'table()'


In src/components/records_list.cr:8:5

 8 | table class: "highlight centered" do
     ^----
Error: instantiating 'table()'


In src/components/records_list.cr:18:7

 18 | tbody do
      ^----
Error: instantiating 'tbody()'


In src/components/records_list.cr:18:7

 18 | tbody do
      ^----
Error: instantiating 'tbody()'


In src/components/records_list.cr:19:17

 19 | records.each do |record|
              ^---
Error: instantiating '(ManufactoryQuery | WorkshopQuery)#each()'


In src/components/records_list.cr:19:17

 19 | records.each do |record|
              ^---
Error: instantiating '(ManufactoryQuery | WorkshopQuery)#each()'


In src/components/records_list.cr:20:11

 20 | tr do
      ^-
Error: instantiating 'tr()'


In src/components/records_list.cr:20:11

 20 | tr do
      ^-
Error: instantiating 'tr()'


In src/components/records_list.cr:23:13

 23 | td do
      ^-
Error: instantiating 'td()'


In src/components/records_list.cr:23:13

 23 | td do
      ^-
Error: instantiating 'td()'


In src/components/records_list.cr:24:43

 24 | link record.name, show.with(record)
                                  ^-----
Error: expected argument #1 to 'Admin::Companies::Create.with' to be (String | Nil), not Manufactory

Overloads are:
 - Admin::Companies::Create.with(anchor : String | ::Nil = nil)

The really wired things is, show.with(record), there never any relation to the Admin::Companies::Create,
Why raise this error instead? it only used in pages/admin/companies/new_page.cr:9 by form_for Create do.

---

The fix is simple, split above components to two, all works fine.

class ManufactoryList < BaseComponent
  needs records : ManufactoryQuery
  needs show : Admin::Manufactories::Show.class
  needs edit : Admin::Manufactories::Edit.class
  needs delete : Admin::Manufactories::Delete.class

class WorkshopList < BaseComponent
  needs records : WorkshopQuery
  needs show : Admin::Workshops::Show.class
  needs edit : Admin::Workshops::Edit.class
  needs delete : Admin::Workshops::Delete.class

So, any idea?

Thanks.

[jwoertink]

That is a strange error. It seems to suggest that you were calling Admin::Companies::Create.with(record) somewhere... Maybe a form?

In any case, I think splitting them is a much better option in the end 👍