Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using Athena Console for CLI #818

Open
jwoertink opened this issue Oct 25, 2023 · 1 comment
Open

Investigate using Athena Console for CLI #818

jwoertink opened this issue Oct 25, 2023 · 1 comment

Comments

@jwoertink
Copy link
Member

Related: #796
Ref: #816

We've had an issue with the CLI in the past where just running lucky -h required your app to compile so it could list out all of the custom tasks you've defined in your app. In the case of some of my apps, running lucky -h would takes upwards of 3+ minutes in development.

To fix this I moved over to using OptionParser #771 and now you can just run lucky -h and get a quick help right away. If you want to see all of your tasks, you'd run lucky tasks. The downside here was #816 where running lucky some.task -h would print out the lucky -h help menu instead. The Crystal OptionParser doesn't have any way to do a "wildcard" type handler. So when you run lucky some.task, the OptionParser really doesn't know what that means. Then passing any flags to it, the parser tries to pull those in.

We can hack around this by using -- to tell the parser to stop parsing, but I think using a built tool might give us more options and flexibility. Athena console comes with tab complletion, and that alone might be worth adding it in. Will need to investigate if it'll be a viable option with how LuckyTask tasks work.

@mdwagner
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants