Skip to content
This repository has been archived by the owner on Jun 24, 2020. It is now read-only.

Memory leak fix and top/bottom bar height ignore option. #46

Merged
merged 3 commits into from Dec 7, 2017

Conversation

matijakregar
Copy link

Data source and delegate variables are set to weak to prevent a retain cycle, which prevents the PagerController objects to deallocate from memory.

ignoreTopBarHeight and ignoreBottomBarHeight options are added so the view can be sized appropriately if it is embedded in as a child view controller (through Container View in storyboard).

@lucoceano
Copy link
Owner

@matijakregar thanks! I'll have a look at the weekend

@musiienko
Copy link

bump

@lfarah
Copy link
Collaborator

lfarah commented Dec 7, 2017

@matijakregar thanks for contributing 👍

@lfarah lfarah merged commit a70d5da into lucoceano:master Dec 7, 2017
@lfarah
Copy link
Collaborator

lfarah commented Dec 7, 2017

@lucoceano can you release a new CocoaPods version please?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants