Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback #39

Closed
case-eee opened this issue Jan 5, 2017 · 0 comments
Closed

Feedback #39

case-eee opened this issue Jan 5, 2017 · 0 comments

Comments

@case-eee
Copy link
Collaborator

case-eee commented Jan 5, 2017 •
edited

  1. Interesting find with the friendly gem. Calling Category.friendly isn't super easy to read or follow... but I think I'm okay with y'all using a gem for this 馃憤

  2. Be sure you have a test for every method in your Cart model (I think you may be missing a few)

  3. Woooo number_to_currency!

  4. Good use of partials 馃帀

  5. Be sure to delete old branches once you've merged them!

@CPowell23 @lucyconklin @ski-climb @robbie-smith don't have a ton of critical feedback for you at this point. good work 馃憤
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@case-eee @CPowell23