Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version number is hard-coded in welcome message #46

Closed
ajjackson opened this issue Aug 18, 2021 · 1 comment · Fixed by #48
Closed

Version number is hard-coded in welcome message #46

ajjackson opened this issue Aug 18, 2021 · 1 comment · Fixed by #48
Assignees
@lucydot
Labels
bug Something isn't working

Comments

@ajjackson
Copy link

The version number message isn't up-to-date with the release numbers.

effmass/effmass/cli.py

Line 12 in dac39d4

print("Welcome to effmass 2.0.0 \U0001F388")

I suggest using something like versioneer to keep version numbers centralised.

(This was found by some ASE user/developers.)
@lucydot
Copy link
Owner

lucydot commented Aug 18, 2021

Thanks for passing this on - I'll take a look at it later today/this week.

@lucydot lucydot self-assigned this Aug 18, 2021
@lucydot lucydot added the bug Something isn't working label Aug 18, 2021
@lucydot lucydot pinned this issue Aug 18, 2021
@lucydot lucydot assigned lucydot and unassigned lucydot Aug 31, 2021
@musicmrman99 musicmrman99 mentioned this issue Sep 6, 2021
Merged
@lucydot lucydot unpinned this issue Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucydot lucydot

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Auto versioning musicmrman99/effmass
2 participants
@lucydot @ajjackson