Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version is not set in pyproject.toml #136

Closed
dvzrv opened this issue Feb 20, 2022 · 2 comments
Closed

Version is not set in pyproject.toml #136

dvzrv opened this issue Feb 20, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@dvzrv
Copy link

dvzrv commented Feb 20, 2022

The problem

Hi! The pyproject.toml of this project declares the version of this project as 0, which is wrong.
The correct version of the python project needs to be declared there (see relevant poetry documentation)

Operating system

Arch Linux

Python version

3.10

Problem-relevant code

version = "0"

Traceback/Error logs

No response

Additional information

If the project's version is not set, sdist tarballs and wheels built from it will have wrong metadata set. This means that other projects will not be able to rely on it without the built package being patched beforehand (they will not be able to use the version information).

This is problematic in general version resolution as well as in system's packaging.

@dvzrv dvzrv added the bug Something isn't working label Feb 20, 2022
@ludeeus
Copy link
Owner

ludeeus commented Feb 20, 2022

@ludeeus ludeeus closed this as completed Feb 20, 2022
@dvzrv
Copy link
Author

dvzrv commented Feb 20, 2022

Okay, but that allows noone to build this project from this git repository or a tarball created from a tag in this repository.
More specifically this allows noone to run tests, as those are not included in the sdist tarball on pypi.org

Please consider changing the workflow as it is limiting the use of this library and/or adding the tests to the sdist tarball.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants