Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

banner.height is reporting back incorrect height #9

Open
mentuat opened this issue Dec 12, 2016 · 1 comment
Open

banner.height is reporting back incorrect height #9

mentuat opened this issue Dec 12, 2016 · 1 comment

Comments

@mentuat
Copy link

mentuat commented Dec 12, 2016

tested on various Android devices - banner.height is always larger than the actual height of the banner.

Sometimes it appears to be twice as much, on other devices a little less

@mentuat
Copy link
Author

mentuat commented Dec 12, 2016

if anyone else is having the same issue and needs a workaround when using admob I took the following ad heights based on device/window height:

32px ≤400dp
50px > 400dp and ≤ 720dp
90px > 720dp

https://firebase.google.com/docs/admob/android/banner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant