-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure the aggregation time interval #142
Comments
Technically its possible, but there are some tradeoffs – currently all the charts are pre-aggregated. That means they are fast to load upon report opening. The thing you are asking for would mean to either create multiple chart versions—the same way it is now, but with different time internals. Or make it live—but that would mean the loading would take much longer (especially for long running tests) and the need to keep all the data, and again with long running tests it might be costly. |
Ok, then I'll live with this limitation. |
I will do some experiments with creating charts with multiple aggregation intervals, eg - one with more points, and one with fewer points. |
@MoritzSalein
And maybe to add some logic, if the interval has less than N points, then to not to display it? Eg. a run of 30mins of runtime would show like only 1 point for an interval of 1 hour. What do you think? |
I think your ideas are very good. It's good to pre process all additional interval and store it in the db. One extra wish of me is an interval of 5 sec. Of course, if it doesn't make sense to display only one point of an graph. If it isn't possible to divide the timespan of an testrun or the result of a division is less 2 then you shouldn't provide this calculated graph. |
There must be an upper limit as well - long runs could be end up with too many points, and that would not make the chart very useful either. |
Very nice :-) |
But you will need to wait for it a bit longer, still a bunch of codes to change and need to make it optional; thus new scenario settings need to be created. |
No problem, I look forward to it. |
@MoritzSalein available in "latest" tag. To test it out, you will need to upgrade be, fe and migration services in docker-compose file. |
Hi @MoritzSalein! By any chance, did you have time to try it out? |
Hi @ludeknovy I have tried out the change. The granularity is available. The graphs changes when I set a different granularity. But I have a problem with the tool tip for the data point of the selected granularity. I addition I have tool tips for data points that are not in the selected graph. In the first screenshot, you'll see a data point for the selection. The second screenshot will shown a data point outside the selection. |
Hi @MoritzSalein. Thanks for the feedback. I am not able to reproduce this locally. From the screenshots, it looks like focus issue - 1) the virtual users line seems to be faded (disabled, inactive?) and thus not shown in the tooltip. 2) Actually, only the virtual users line seems to be active. Based on the font rendering, I can see the app looks a bit different - what browser/platform do you use? |
I can confirm that there seem to be issues when hovering over the graph. I can either get labels for all datapoints except the virtual users to show up, or the virtual users on their own without any of the other datapoints. It's quite erratic behaviour and hard to explain in screenshots. I recorded a little video in Firefox version 100.0 (😎): 2022-05-06.15-18-44.mp4 |
Hi @csvtuda ! I understand the issue, but still not able to reproduce it :| I tried FF as well, and it behaves correctly - could you try another browser? Screen.Recording.2022-05-06.at.16.01.01.mov |
Yes, the issue also persists in Chrome, Version 101.0.4951.54 (64-Bit). In both browsers it only appears when using aggregation types other than FYI: I'm using a local build of the JTL reporter with the following commits checked out:
Edit: I just tried the docker hub version using Feel free to attach the log file you're using for your report, maybe I can double check against your functioning report. I would like to attach mine, but some of its contents are confidential unfortunately :( |
@ludeknovy On my own installation I get the problem with Firefox, Edge and Chrome. The problem is not with the Auto aggregation. Only when I switch to another aggregation. |
Unfortunately, I still cannot replicate it - even with "hostname" included. Could you, please, anonymize the labels/hostname and share the .jtl file with me? |
Okay so I just tried again with anonymized request labels and an arbitrary IP for hostname and it worked fine, no issue whatsoever. I then anonymized step-by-step and to me it looks like multiple host names are the cause. When I replace them with a single hostname, everything works smoothly. I attached a mini report containing different host names: results_mini.csv. |
@csvtuda Thanks! Now I am able to reproduce it. 👀 |
I hope I found it and should be fixed now. If you want to test it, update jtl-reporter-be to the latest commit in master branch |
Looks good to me, thank you very much! Also works for the big thing if I reimport it. How about you, @MoritzSalein? |
It works perfectly now on my installation. Thank you. |
Currently the charts calculate aggregation time interval themselve. But sometimes it will be helpful to see the interval less detailed. E.g. in a 10 minute run, my chart shows every 3 Second and some Miliseconds a new point in the graph. For this it will be good to set the interval in the settings with an individual value like 10 Seconds, 1 Minute or another.
It it possible to integrate such setting for the interval?
The text was updated successfully, but these errors were encountered: