Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dynamic change of rows in the table. #10

Closed
wants to merge 5 commits into from
Closed

Support for dynamic change of rows in the table. #10

wants to merge 5 commits into from

Conversation

whittet
Copy link

@whittet whittet commented Apr 11, 2011

Expander no longer uses margin-left (Resolved issue #2 and/or #9).
Added treeTableRow method which allows initializing new rows added to the table. This change required Expander to only be added the first time.

@konrad-garus
Copy link

What exactly is treeTableRow supposed to do? How is it different from:

$(row).appendBranchTo($(parent));

@whittet
Copy link
Author

whittet commented Jul 11, 2011

Did you read my comment? In simple terms, the treeTable does not support adding rows using javascript. So I created a method which adds this support to new rows. newRow.treeTableRow();

Please let me know if you find that this is not necessary!

Sorry I did not reply immediately, I was on vacation:)

@konrad-garus
Copy link

I believe this can be accomplished with:

$(parentRow).after('<tr id="new_child">...</tr>');
$('#new_child').appendBranchTo($parentRow);

@whittet
Copy link
Author

whittet commented Jul 15, 2011

My use case is adding N rows and then calling rootRow.treeTableRow() to set them up.

@whittet whittet closed this Jul 15, 2011
@whittet whittet reopened this Jul 15, 2011
@ludo
Copy link
Owner

ludo commented Jul 30, 2011

The diff is rather difficult to read because the indentation changed. Unfortunately I don't have the time to look into this now. Would it be possible for you to update the pull request without the indentation changes? That would help a lot :)

@whittet
Copy link
Author

whittet commented Jul 30, 2011

Sure, thing. Visual Studio "helping" with code formatting, sorry.

@whittet whittet closed this Jul 30, 2011
@whittet whittet reopened this Jul 30, 2011
@whittet
Copy link
Author

whittet commented Aug 1, 2011

I cannot get to this until next week. Have you tried WinMerge or similar tool?

@whittet
Copy link
Author

whittet commented Sep 7, 2011

Going to refork and resubmit pull request.

@whittet whittet closed this Sep 7, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants