Add a clear error message about invalid column names in GBM datasets #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaddair
reviewed
Dec 24, 2022
ludwig/trainers/trainer_lightgbm.py
Outdated
| raise ValueError( | ||
| "Some column names in the training set contain invalid characters. Please ensure column names only " | ||
| "contain alphanumeric characters and underscores, then try training again." | ||
| ) |
There was a problem hiding this comment.
You can do raise ValueError(...) from e to retain the original exception as well.
There was a problem hiding this comment.
This should be addressed in b4a0fc5!
tgaddair
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When prepping data for GBM training/eval, column names with invalid characters may cause
lightgbm.Datasetto throw the following error:This update catches the
LightGBMErrorand provides more descriptive feedback.