Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

一点小建议 #6

Closed
mr258876 opened this issue Apr 1, 2021 · 5 comments
Closed

一点小建议 #6

mr258876 opened this issue Apr 1, 2021 · 5 comments

Comments

@mr258876
Copy link

mr258876 commented Apr 1, 2021

作者大大好！首先感谢大佬的代码，之前也想用python做这个只是最后按键没能实现😂，今天看到这个项目以后感觉获益匪浅。
在使用过程中我发现有几个地方可以改进：
1.可以在开始弹奏之前加一个倒计时方便切窗口
2.在部分多音轨的midi谱中存在多个音轨同时演奏一个音的情况，可能会导致同一个键被重复按下，在演奏之前遍历一边midi文件并把重复的音删掉应该可以解决这个问题
目前就发现这两个
@luern0313
Copy link
Owner

1正在做
2的话。。重复按下不影响演奏的吧，如果两个音开始时间相同的话

@luern0313
Copy link
Owner

如果两个音不同时开始，只是时间有重合不影响的，原神这个琴是只看按下的时间再加个延时而已

@mr258876
Copy link
Author

mr258876 commented Apr 1, 2021

感谢解答！
顺便问下能不能把这首歌放进去？
Doki Doki Literature Club!.zip

@luern0313
Copy link
Owner

这个应该可以直接用吧

@luern0313
Copy link
Owner

加上去了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luern0313 @mr258876