Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in ROCCH.Bayes_error_rate #1

Open
bsxfan opened this issue Feb 22, 2021 · 0 comments
Open

Bug in ROCCH.Bayes_error_rate #1

bsxfan opened this issue Feb 22, 2021 · 0 comments

Comments

@bsxfan
Copy link

bsxfan commented Feb 22, 2021

Try this:

scores = np.array([1.0,2.0,3.0])
labels = np.array([0,0,1])
rocch = ROCCH(PAV(scores,labels))
ber, pmiss, pfa = rocch.Bayes_error_rate(-np.inf,True)

This gives ber, pmiss, pfa = (0,0,0), but pfa should be 1. The ROCCH is correctly computed and so is ber. But sometimes pmiss or pfa is not. The problem is here. The relevant vertex of the ROCCH is found by minimization. But sometimes, the minimum is not unique. The value of the minimum is the Bayes error-rate ber, which is then correct. But the wrong index sometimes happens to be chosen, returning the wrong pmiss or pfa.

I will figure out how to fix this.

Niko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant