Add Windows support #492
Add Windows support #492
Conversation
Add support for react-native-windows. Update the docs and example and add an automatic CI test.
|
| @@ -32,7 +32,7 @@ Install the package: | |||
| $ yarn add react-native-config | |||
| ``` | |||
|
|
|||
| Link the library: | |||
| Link the library (not supported on Windows, use manual linking): | |||
There was a problem hiding this comment.
we added autolinking to rnw on 63 (?) @jonthysell to confirm
There was a problem hiding this comment.
It did not work for me. I've opened an issue for that: microsoft/react-native-windows#6024
| let nativeCode = ''; | ||
| // React Native Module code | ||
| let rnCode = ''; | ||
| nativeCode += '#include<string>\n' |
| updateFile(nativeCode, path.join(outDir, 'RNCConfigValues.h')) | ||
| updateFile(rnCode, path.join(outDir, 'RNCConfigValuesModule.inc.h')) |
There was a problem hiding this comment.
consider naming these with .g to mark that they are autogenerated
| const escaped = escapeString(value) | ||
| nativeCode += ` inline static std::string ${key} = ${escaped};\n` | ||
| rnCode += `REACT_CONSTANT(${key});\n` | ||
| rnCode += `static inline const std::string ${key} = ${escaped};\n`; |
There was a problem hiding this comment.
these could be made constexpr instead and get rid of the nativeCode?
There was a problem hiding this comment.
+1 on constexpr
I did two files to have a simpler namespace for the values in native code - i.e. ReactNativeConfig::something instead of RNCConfig::ReactNativeConfigModule::something
|
@bzoz thanks for adding Windows support; unfortunately, the windows build seems to fail in GitHub Actions. Do you have any time to have a quick glance? I assume you have the most experience with the platform having contributed this (I have just a mac). I fixed one issue with msbuild, but there remains an error about having two similarly named solutions. https://github.com/hermanbanken/react-native-config/runs/5432726750?check_suite_focus=true |
Add support for react-native-windows.
Update the docs and example and add an automatic CI test.