Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: escape cp for PROJECT_DIR with spaces #504

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

skimi
Copy link
Contributor

@skimi skimi commented Oct 6, 2020

Small update to the doc to take into account that PROJECT_DIR may contain spaces and should be "escaped" so that the cp works in those cases.

I had the issue on my project where it worked well locally and failed in the CI because the CI had a space in PROJECT_DIR.

Since like me most people will copy paste the cp line from the readme it's worthwhile updating it so less people get this issue

@height
Copy link

height bot commented Oct 6, 2020

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Collaborator

@luancurti luancurti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@luancurti luancurti merged commit 907be7e into lugg:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants