Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for version 0.2.0 #11

Merged
merged 13 commits into from Sep 17, 2021
Merged

Proposal for version 0.2.0 #11

merged 13 commits into from Sep 17, 2021

Conversation

leynier
Copy link
Collaborator

@leynier leynier commented Sep 15, 2021

Breaking changes

  • user_id of Transaction model was removed
  • paid_by_user_id of Transaction model was removed

The reason is that the API stopped sending those properties.

Features

Resolve #9

@leynier
Copy link
Collaborator Author

leynier commented Sep 15, 2021

That the tests fail should not be an impediment to accept the pull request, when the pull request be merged and the tests run on the main branch they will run fine.

@leynier leynier self-assigned this Sep 16, 2021
@leynier leynier added the enhancement New feature or request label Sep 16, 2021
@CarlosLugones CarlosLugones merged commit ec097c9 into ragnarok22:main Sep 17, 2021
@CarlosLugones
Copy link
Contributor

Thanks a lot @leynier for your PR, greatly done! 👏

CarlosLugones added a commit that referenced this pull request Oct 20, 2022
Proposal for version 0.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement test that raises errors of QvaPayAuth for Coverage 100%
2 participants