feat: split implementation in two classes #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "_sync" folders were generated automatically executing the command "unasync qvapay tests". The code that is added in the "_async" folders are automatically transformed. So every time to make a change you must run the command "unasync qvapay tests" to regenerate the folders "_sync" with the synchronous version of the implementation.
leynier
changed the title
leynier
changed the title
|
@leynier sorry for the delay, I didn't see any notification related to this. Checking it now. |
CarlosLugones
approved these changes
Oct 30, 2021
CarlosLugones
added a commit
that referenced
this pull request
Oct 20, 2022
feat: split implementation in two classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BREAKING CHANGES]QvaPayClientwas divided into two classes:AsyncQvaPayClientandSyncQvaPayClient. Both classes have the same methods and properties, with the difference that the methods inAsyncQvaPayClientare asynchronous and inSyncQvaPayClientare synchronous.The
_syncfolders were generated automatically executing the commandunasync qvapay tests.The code that is added in the
_asyncfolders is automatically transformed.So every time to make a change you must run the command
unasync qvapay teststo regenerate the folders_syncwith the synchronous version of the implementation.Improve
testsimplementation and addpre-commitsystem to ensure format and style.