Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icons are displayed incorrectedly #5

Closed
seagle0128 opened this issue Oct 13, 2023 · 0 comments · Fixed by #6
Closed

icons are displayed incorrectedly #5

seagle0128 opened this issue Oct 13, 2023 · 0 comments · Fixed by #6

Comments

@seagle0128
Copy link
Contributor

seagle0128 commented Oct 13, 2023 •
edited
Loading

I am using the latest nerd-icons-corfu with Emacs 29.1 on Windows 11, and got this issue. The screenshot is below.

nerd-icons-font-family is "Symbols Nerd Font Mono".

image

The root cause is here:

nerd-icons-corfu/nerd-icons-corfu.el

Lines 131 to 132 in 2e546d1

(when-let ((extra-face (plist-get icon-entry :face)))
(put-text-property 0 3 'face extra-face str))

seagle0128 added a commit to seagle0128/nerd-icons-corfu that referenced this issue Oct 13, 2023
@seagle0128
fix: LuigiPiucco#5 the icons are displayed incorrectly
fcd190b
@seagle0128 seagle0128 mentioned this issue Oct 13, 2023
Merged
LuigiPiucco pushed a commit that referenced this issue Oct 15, 2023
@seagle0128
Merge pull-request #6 from seagle0128/fix-icon-face
48aca33 
* fix: #5 the icons are displayed incorrectly

Use `:face` argument to the icon functions instead of manual property setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: icons are displayed incorrectly seagle0128/nerd-icons-corfu
1 participant
@seagle0128