Emits "error" when all sentinels are unreachable. Close #200

redis · Nov 25, 2015 · 34ed2c5 · 34ed2c5
1 parent 65dc474
commit 34ed2c5
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -4,6 +4,8 @@ This file is a manually maintained list of changes for each release. Feel free t
 
 ## Master Branch (Unreleased)
 
+* [Sentinel] Emits "error" when all sentinels are unreachable ([#200](https://github.com/luin/ioredis/issues/200)).
+
 ## v1.11.0 - November 19, 2015
 
 * Emits "select" event when the database changed.

diff --git a/lib/redis.js b/lib/redis.js
@@ -259,6 +259,7 @@ Redis.prototype.connect = function (callback) {
     this.connector.connect(function (err, stream) {
       if (err) {
         _this.flushQueue(err);
+        _this.silentEmit('error', err);
         reject(err);
         return;
       }

diff --git a/test/functional/sentinel.js b/test/functional/sentinel.js
@@ -65,10 +65,22 @@ describe('sentinel', function () {
       });
 
       redis.get('foo', function (error) {
+        finish();
         expect(error.message).to.match(/are unreachable/);
-        redis.disconnect();
-        done();
       });
+
+      redis.on('error', function (error) {
+        expect(error.message).to.match(/are unreachable/);
+        finish();
+      });
+
+      var pending = 2;
+      function finish() {
+        if (!--pending) {
+          redis.disconnect();
+          done();
+        }
+      }
     });
 
     it('should close the connection to the sentinel when resolving successfully', function (done) {