Skip to content

Commit

Permalink
chore: switch from single lodash library to functions required (#494)
Browse files Browse the repository at this point in the history
  • Loading branch information
chris-olszewski authored and luin committed Aug 13, 2017
1 parent 8e17920 commit 58dc630
Show file tree
Hide file tree
Showing 13 changed files with 45 additions and 12 deletions.
2 changes: 1 addition & 1 deletion lib/cluster/connection_pool.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
var util = require('util');
var utils = require('../utils');
var EventEmitter = require('events').EventEmitter;
var _ = require('lodash');
var _ = require('../utils/lodash');
var Redis = require('../redis');

function ConnectionPool(redisOptions) {
Expand Down
2 changes: 1 addition & 1 deletion lib/cluster/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ var utils = require('../utils');
var util = require('util');
var EventEmitter = require('events').EventEmitter;
var debug = require('debug')('ioredis:cluster');
var _ = require('lodash');
var _ = require('../utils/lodash');
var ScanStream = require('../scan_stream');
var Commander = require('../commander');
var Command = require('../command');
Expand Down
2 changes: 1 addition & 1 deletion lib/command.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

var _ = require('lodash');
var _ = require('./utils/lodash');
var Promise = require('bluebird');
var fbuffer = require('flexbuffer');
var utils = require('./utils');
Expand Down
2 changes: 1 addition & 1 deletion lib/commander.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

var _ = require('lodash');
var _ = require('./utils/lodash');
var Command = require('./command');
var Script = require('./script');
var Promise = require('bluebird');
Expand Down
2 changes: 1 addition & 1 deletion lib/connectors/connector.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

var _ = require('lodash');
var _ = require('../utils/lodash');
var net = require('net');
var tls = require('tls');
var utils = require('../utils');
Expand Down
2 changes: 1 addition & 1 deletion lib/connectors/sentinel_connector.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

var _ = require('lodash');
var _ = require('../utils/lodash');
var util = require('util');
var net = require('net');
var utils = require('../utils');
Expand Down
2 changes: 1 addition & 1 deletion lib/pipeline.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
var _ = require('lodash');
var _ = require('./utils/lodash');
var Commander = require('./commander');
var Command = require('./command');
var fbuffer = require('flexbuffer');
Expand Down
2 changes: 1 addition & 1 deletion lib/redis.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

var _ = require('lodash');
var _ = require('./utils/lodash');
var util = require('util');
var EventEmitter = require('events').EventEmitter;
var Promise = require('bluebird');
Expand Down
2 changes: 1 addition & 1 deletion lib/redis/event_handler.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
var debug = require('debug')('ioredis:connection');
var Command = require('../command');
var utils = require('../utils');
var _ = require('lodash');
var _ = require('../utils/lodash');

exports.connectHandler = function (self) {
return function () {
Expand Down
2 changes: 1 addition & 1 deletion lib/redis/parser.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

var _ = require('lodash');
var _ = require('../utils/lodash');
var Command = require('../command');
var SubscriptionSet = require('../subscription_set');
var debug = require('debug')('ioredis:reply');
Expand Down
2 changes: 1 addition & 1 deletion lib/utils/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';
var urllib = require('url');
var _ = require('lodash');
var _ = require('./lodash');

/**
* Test if two buffers are equal
Expand Down
18 changes: 18 additions & 0 deletions lib/utils/lodash.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
'use strict';

exports.forEach = require('lodash.foreach');
exports.pick = require('lodash.pick');
exports.assign = require('lodash.assign');
exports.defaults = require('lodash.defaults');
exports.noop = require('lodash.noop');
exports.difference = require('lodash.difference');
exports.clone = require('lodash.clone');
exports.sample = require('lodash.sample');
exports.flatten = require('lodash.flatten');
exports.bind = require('lodash.bind');
exports.keys = require('lodash.keys');
exports.isEmpty = require('lodash.isempty');
exports.values = require('lodash.values');
exports.shuffle = require('lodash.shuffle');
exports.partial = require('lodash.partial');
exports.cloneDeep = require('lodash.clonedeep');
17 changes: 16 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,22 @@
"debug": "^2.2.0",
"denque": "^1.1.0",
"flexbuffer": "0.0.6",
"lodash": "^4.8.2",
"lodash.assign": "^4.2.0",
"lodash.bind": "^4.2.1",
"lodash.clone": "^4.5.0",
"lodash.clonedeep": "^4.5.0",
"lodash.defaults": "^4.2.0",
"lodash.difference": "^4.5.0",
"lodash.flatten": "^4.4.0",
"lodash.foreach": "^4.5.0",
"lodash.isempty": "^4.4.0",
"lodash.keys": "^4.2.0",
"lodash.noop": "^3.0.1",
"lodash.partial": "^4.2.1",
"lodash.pick": "^4.4.0",
"lodash.sample": "^4.2.1",
"lodash.shuffle": "^4.2.0",
"lodash.values": "^4.3.0",
"redis-commands": "^1.2.0",
"redis-parser": "^2.4.0"
},
Expand Down

0 comments on commit 58dc630

Please sign in to comment.