fix: passing in family parameter in URL in node 18 (#1673)

redis · Nov 2, 2022 · 6f1ab9f · 6f1ab9f
1 parent 4de8cdb
commit 6f1ab9f
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/lib/utils/index.ts b/lib/utils/index.ts
@@ -236,6 +236,12 @@ export function parseURL(url: string): Record<string, unknown> {
   if (parsed.port) {
     result.port = parsed.port;
   }
+  if (typeof options.family === "string") {
+    const intFamily = Number.parseInt(options.family, 10);
+    if (!Number.isNaN(intFamily)) {
+      result.family = intFamily;
+    }
+  }
   defaults(result, options);
 
   return result;

diff --git a/test/unit/redis.ts b/test/unit/redis.ts
@@ -96,6 +96,9 @@ describe("Redis", () => {
           tls: { hostname: "example.test" },
         });
         expect(option.tls).to.deep.equal({ hostname: "example.test" });
+
+        option = getOption("redis://localhost?family=6");
+        expect(option).to.have.property("family", 6);
       } catch (err) {
         stub.restore();
         throw err;

diff --git a/test/unit/utils.ts b/test/unit/utils.ts
@@ -195,6 +195,14 @@ describe("utils", () => {
         password: "pass",
         key: "value",
       });
+      expect(utils.parseURL("redis://127.0.0.1/?family=6")).to.eql({
+        host: "127.0.0.1",
+        family: 6,
+      });
+      expect(utils.parseURL("redis://127.0.0.1/?family=IPv6")).to.eql({
+        host: "127.0.0.1",
+        family: "IPv6",
+      });
     });
   });