Force disconnect after a timeout if socket is still half-open #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioredis-robot
pushed a commit
that referenced
this pull request
Mar 31, 2021
## [4.24.6](v4.24.5...v4.24.6) (2021-03-31) ### Bug Fixes * force disconnect after a timeout if socket is still half-open ([#1318](#1318)) ([6cacd17](6cacd17))
|
🎉 This PR is included in version 4.24.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.24.6](redis/ioredis@v4.24.5...v4.24.6) (2021-03-31) ### Bug Fixes * force disconnect after a timeout if socket is still half-open ([#1318](redis/ioredis#1318)) ([6cacd17](redis/ioredis@6cacd17))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #1314, if the Redis server is made unreachable with the
DEBUG SLEEPcommand ordocker pause, the connection hangs in such a way thatsocket.end()can leave it indefinitely in a half-closed state, which doesn't trigger a reconnect.This PR fixes it so that if the socket doesn't fully close in 2 seconds (configurable via the new
disconnectTimeoutoption), it is destroyed.