Cluster subscribe does not work when TLS is enabled for AWS Redis Cluster

[andrewm42]

Tested Using

• Node.js v10.13.0
• ioredis v4.5.1
• AWS Clustered Redis Elasticache (3 nodes, in-transit and at-rest encryption enabled)

Problem

Disabling TLS breaks the pub/sub subscribe functions for me. I have tried everything in this post: #754 to resolve it but I always get this error:

MaxRetriesPerRequestError: Reached the max retries per request limit (which is 20). Refer to "maxRetriesPerRequest" option for details

Example

This occurs when using the simple example below:

  const nodes = [{
      host: ...,
      port: ...,
  }];
  const redisOptions = {
      tls: {},
  };
  const clusterOptions = {
      redisOptions: redisOptions,
      dnsLookup: (address, callback) => callback(null, address),
  };

  const redis = new Redis.Cluster(nodes, clusterOptions);
  const pub = new Redis.Cluster(nodes, clusterOptions);

  redis.subscribe('mychannel1', (err, count) => {
    console.log(err);
    pub.publish('mychannel1', 'Hello world!');
  });

  redis.on('message', (channel, message) => {
    console.log(`Received message ${message} from channel ${channel}`);
  });

Publish works fine. Subscribe does not. Has anyone else encountered this error?

[r3b-fish]

It's possible solution but I think instantiation of subscriber should be more elegant

diff --git a/lib/cluster/ClusterSubscriber.ts b/lib/cluster/ClusterSubscriber.ts
index 11c1e0b..c176bec 100644
--- a/lib/cluster/ClusterSubscriber.ts
+++ b/lib/cluster/ClusterSubscriber.ts
@@ -71,7 +71,8 @@ export default class ClusterSubscriber {
       password: options.password,
       enableReadyCheck: true,
       connectionName: SUBSCRIBER_CONNECTION_NAME,
-      lazyConnect: true
+      lazyConnect: true,
+      tls: options.tls
     })

[ioredis-robot]

🎉 This issue has been resolved in version 4.6.2 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀