Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions lost after reconnection #85

Closed
tzanko-matev opened this issue Jun 30, 2015 · 2 comments
Closed

Subscriptions lost after reconnection #85

tzanko-matev opened this issue Jun 30, 2015 · 2 comments
Labels

Comments

@tzanko-matev
Copy link

Steps to reproduce:

  1. Start Redis
  2. Start a ioredis client with no options given and subscribe to a channel. When we run 'PUBSUB CHANNEL' in redis-cli, the subscription should show
  3. Kill the redis process and start it again. Now 'PUBSUB CHANNEL' shows nothing.

After I looked a little bit at the code it seemed that when the client reconnects it checks the property prevCondition.subscriber to see if the client was in subscribe mode and to renew all subscriptions. However the value of this property is 'false', so the subscriptions are not renewed.

@luin luin added the bug label Jun 30, 2015
@luin luin closed this as completed in 82cff83 Jun 30, 2015
@luin
Copy link
Collaborator

luin commented Jun 30, 2015

This issue happens when reconnecting failed more than one times. Fixed in the master branch. Thanks for reporting.

@tzanko-matev
Copy link
Author

Thank you for the quick reaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants