Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2 breaks when callback param is not passed in #33

Closed
nathanwdavis opened this issue Sep 10, 2013 · 1 comment
Closed

v1.2 breaks when callback param is not passed in #33

nathanwdavis opened this issue Sep 10, 2013 · 1 comment

Comments

@nathanwdavis
Copy link

Following the discussion about the need for a callback, it seems that it was intended to be an optional thing. I think it would be pretty easy to check that callback exists and is a function before calling it. Something like:

if (typeof(v) == "function") {
    callback.call(this);
} 

...should do the trick. I would just do a PR myself, but it appears tag 1.2.0 isn't even off master, so might be easier to just do this yourself in your futures branch or whatever.

Also, FYI... I encountered this because bowers now pointed at 1.2.0 as current.

@luis-almeida
Copy link
Owner

Thanks for spotting this!
It was due to me experimenting on this project at 2am, committing and tagging shit code that wasn't completely reverted as I intended to.
I just pushed a proper v1.2.0 with a working callback and proper documentation.
I'm sorry for any inconvenience I might have caused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants