time to refactoring ?

[adyba]

I know it is a development version and I know Angular doesn't have strict rules what pattern should do what, but there are some issues that should be addressed. I believe the huge Facebook provider should be split into infrastructure settings (provider) and the communication part (client <=> FB SDK/API) should be (any kind of) service.
Such service could be consumed by controllers and directives. For security and other reasons there should be a 'fb-logged' html attribute instead of $scope.logged variable inside the controller or several controllers. Such attribute and other HTML suggars would help integrate the code with other auth providers across the whole app (account&permission management, navbar, views, etc.)

[mrzmyr]

@adyba this module has already a provider (FacebookProvider) and a service (Facebook) and it can be consumed by a controller as you can see in the usage section:

.controller('authenticationCtrl', function($scope, Facebook) {

or with a directive

.directive('customDirective', function(Facebook) {

When you need a fb-logged html attribute you can write a custom directive and use the Facebook service with it like in the example above.

[mrzmyr]

If you still have ideas, please open a new issue. When i got you wrong, please comment. For now I will close the issue.

[adyba]

Satellizer does it exactly the way Auth should work.