Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bot.py #14

Open
luisgc93 opened this issue Jan 23, 2021 · 2 comments
Open

Refactor bot.py #14

luisgc93 opened this issue Jan 23, 2021 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@luisgc93
Copy link
Owner

luisgc93 commented Jan 23, 2021

Just how the test suite was split into several modules, the same should probably be done for bot.py since the code is getting a bit spaghetti.

Some ideas of how it could be broken down:

  • Modules for methods with outside API calls vs methods that don't have outside calls
  • One module for each feature e.g. reply_mentions.py, publish_reminders.py, generate_report.py
@luisgc93 luisgc93 added the help wanted Extra attention is needed label Jan 23, 2021
@luisgc93
Copy link
Owner Author

luisgc93 commented Feb 7, 2021

It might make sense to follow a composition approach as in:
luisgc93/chamath2cash@9c9b706
I.e. To create a Bot class that contains all the different clients plus some business logic.

@luisgc93 luisgc93 self-assigned this Feb 27, 2021
@luisgc93
Copy link
Owner Author

WIP in branch refactor-with-composition-approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant