Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Guice #222

Closed
Captain-P-Goldfish opened this issue Mar 8, 2021 · 1 comment
Closed

Update Guice #222

Captain-P-Goldfish opened this issue Mar 8, 2021 · 1 comment
Assignees
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@Captain-P-Goldfish
Copy link

When creating a xades signature we are getting the following warning in the log:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.ReflectUtils$2 (file:/D:/maven-repository/com/google/inject/guice/2.0/guice-2.0.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.ReflectUtils$2
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

Updating the responsible dependencies in the dependencyManagement might work without problems, but it would be cleaner if xades4j would use a clean set of dependency versions

            <dependency>
                <groupId>com.google.inject.extensions</groupId>
                <artifactId>guice-multibindings</artifactId>
                <version>4.2.3</version>
            </dependency>
            <dependency>
                <groupId>com.google.inject</groupId>
                <artifactId>guice</artifactId>
                <version>5.0.1</version>
            </dependency>
@luisgoncalves luisgoncalves self-assigned this Mar 13, 2021
@luisgoncalves luisgoncalves added the dependencies Pull requests that update a dependency file label Mar 13, 2021
@luisgoncalves luisgoncalves modified the milestones: v1.6.0, vNext Mar 13, 2021
@luisgoncalves
Copy link
Owner

I wasn't sure this would be a drop-in replacement, but looks like it is. I've updated it and did some additional cleanup.

@luisgoncalves luisgoncalves changed the title Please update guice-multibindings Update Guice Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants