-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive menu? #93
Comments
Yes, we have and mobile menu. It should display in 768px or less screens. |
@jemostrom how did you test this? I mean is this a local clone of this theme? Are you sure you have the updated theme in your site? |
We use
Looks like you are resizing our browser window, and this will not trigger the mobile menu because your You can test the mobile menu using the Developers Tools from your browser. |
I'm probably too stupid to do things correctly (I'm not doing any web design so ...) but on Safari I enter the responsive mode and select one of the available iPhones ... and it looks like this Am I doing something wrong here. Also, if I make my window narrow on my laptop shouldn't I also get the responsive menu? My thinking is that I might have several windows open and have made windows narrow so they can be viewed at the same time. |
Firefox seem to do it correctly. I also checked the example site using my 6s Plus and it looks OK there also. So apparently it's Safari on my laptop that is doing something wrong. But I'm still curious why the decision not show a "hamburger menu" on my laptop for narrow windows. |
FWIW - I did change |
Wierd. Can you give me the version of your Safari? Maybe we need to add an extra rule or something to make it work on Safari. Need some research.
Not yet. I need to write something. But you will need to use Hugo Extended v0.43 or more to compile the SCSS into CSS. The command |
Yes, it's basically how to build the css files I need help with, the scss files looks almost like normal css files so I think handle that part. Safari: Version 12.0 (14606.1.36.1.9) |
I did some quick research and it seems like
With that said, all I can create a PR for this if you're OK with the proposed change. |
@josephting sure. I would appreciate it. |
I've been playing with the theme and to me it looks like the menu doesn't display as an "hamburger menu" for narrow screens. Is this the intended design or am I missing something? (yep Hugo newbie)
The text was updated successfully, but these errors were encountered: