-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error while starting #23
Comments
Hi @dalisoft, it seems like your machine doesn't have support to SIMD. When I check in my machine, I get something like:
I think As for the crash, I think my bindings are not working 100%, since the expected behaviour is handling it gracefully rather than crashing. It should have compiled with the Thanks for opening this issue, I really appreciate the contribution! |
Hi @luizperes Yes, i think my machine doesn't support AVX2 and/or SSE4, but i expected falling back to Thank you too for such great library, i want use this library on my library for improving I currently using |
Hi @dalisoft, Yes, you're completely right. That is exactly how it should work. Thank you too for being enthusiastic in using it! Truth being told, I really only made it available for node, the hard work is done at the original repo :) I already have an idea of how the crash is happening. If I were to guess, it is because of my config file, more precisely around here. I also discovered that there is an issue open for it (#3). I don't have much time to work on it these next couple weeks (doing my masters final reports, reviewing papers and such). But I can totally take a look around mid-April. I will let you know once I fix it and that would also be nice if you could validate it (since we should test in a config like yours). Meanwhile, I don't know if you are any comfortable with Thanks again! |
@luizperes Yes, hard work made by simdjson community/team, but for node.js community hard work made by you and community of simdjson-node did, so from node.js community all thanks goes to you. About your time, yep, i understand, i also does not have time, while searching i found library and i choose your library from one of 3-4 libraries because your library does what i need and works stable yet (exclude current issue). |
Right! Checking #3, Lemire said that Will let you know once I do it! Cheers! |
It is correct, the upcoming version 0.3 of simdjson will run basically everywhere. I expect we will be releasing it in a few days. cc @jkeiser |
Hi @dalisoft, I updated the bindings to the latest version of |
Hi @luizperes. Yes, it works, but very slow compared to native Example of benchmark code: bench.jsconst turboJson = require("turbo-json-parse");
const simdJson = require("simdjson");
const bench = (name, fn) => {
console.time(name);
for (let i = 0; i < 200000; i++) {
fn();
}
console.timeEnd(name);
};
const SCHEMA = {
type: "object",
properties: {
foo: { type: "string" }
}
};
const JSON_BUFF = `{
"foo": "bar"
}`;
const TURBO_COMPILE = turboJson(SCHEMA, {
fullMatch: true,
validate: false,
defaults: false,
buffer: false
});
bench("json.parse", () => JSON.parse(JSON_BUFF));
bench("simdjson", () => simdJson.parse(JSON_BUFF));
bench("turbo.parse", () => TURBO_COMPILE(JSON_BUFF)); calling$ node bench.js resultsjson.parse: 190.99ms
simdjson: 829.617ms
turbo.parse: 81.068ms ~4-5 times slower, currently did not tested on AVX machines, i think in few days can test in AVX devices too |
Hi @dalisoft, this problem is described on issue #5. Also, please read the If you want to get its full power, use the function Because your initial issue is fixed, I will close it. Feel free to open new issues in case you find any, cheers! |
@luizperes Yes, current issue was fixed. Thanks. Great project and nice maintainer as you fixed issue in less than week :) |
Hi @luizperes and thanks for such great project.
I'm tried run this project, but there got some errors.
nodemon
node + fish shell
node + zsh shell
node + bash
dalisoft@dalisofts-MBP turbo-json % bash The default interactive shell is now zsh. To update your account to use zsh, please run `chsh -s /bin/zsh`. For more details, please visit https://support.apple.com/kb/HT208050. bash-3.2$ node bench-json-str.js Illegal instruction: 4
instructions
bash-3.2$ sysctl -a | grep machdep.cpu.leaf7_features machdep.cpu.leaf7_features: RDWRFSGS SMEP ERMS MDCLEAR IBRS STIBP L1DF SSBD
Env
The text was updated successfully, but these errors were encountered: