Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color for a selected file #22

Closed
TofPlay opened this issue Sep 30, 2018 · 7 comments
Closed

Color for a selected file #22

TofPlay opened this issue Sep 30, 2018 · 7 comments
Labels
bug Something isn't working

Comments

@TofPlay
Copy link

TofPlay commented Sep 30, 2018

image
When we select a file we can hardly read his name

@lukakerr lukakerr added the hacktoberfest Possible Hacktoberfest issue label Oct 6, 2018
@damien-rivet
Copy link

damien-rivet commented Oct 17, 2018

Hi,

I'll be working on the issue and opening a PR soon ;-)

You might want to also add an issue to upgrade the support to MacOS 10.14 for Dark Mode compatibility.

@lukakerr
Copy link
Owner

Awesome @Ethenyl ! For dark mode Twig actually already supports it, you just need to enable the system theme in preferences

@damien-rivet
Copy link

Hi @TofPlay,

Can you give me more information about your macOS settings :

  • Appearance
  • Accent colour
  • Highlight colour

I've tried different settings and I can't reproduce the same effect as your screenshot.

@TofPlay
Copy link
Author

TofPlay commented Oct 17, 2018

@Ethenyl sure!
image
I hope it's will help

@damien-rivet
Copy link

damien-rivet commented Oct 19, 2018

Thanks @TofPlay, but I was mainly referring to your macOS theme option (the one from the System Preferences's General panel.

Judging from the screens you provided, you're using Dark Mode with Graphite accent colour.

Currently, I'm unable to reproduce the issue with the different combination of settings I've tested.

@TofPlay
Copy link
Author

TofPlay commented Oct 19, 2018

I'm on macOS Hight Sierra 10.13.6

@lukakerr lukakerr added bug Something isn't working help wanted Extra attention is needed and removed hacktoberfest Possible Hacktoberfest issue labels Feb 9, 2019
@lukakerr lukakerr removed the help wanted Extra attention is needed label Feb 18, 2019
@lukakerr
Copy link
Owner

I believe this should be fixed in cfbfaab#diff-7d7207b5d9425d357c97cb86046ef748R259.

If you still experience this problem after the next release, feel free to re-open this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants