Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #2

Closed
elfring opened this issue Oct 25, 2016 · 5 comments
Closed

reserved identifier violation #2

elfring opened this issue Oct 25, 2016 · 5 comments

Comments

@elfring
Copy link

elfring commented Oct 25, 2016

I would like to point out that an identifier like "__LLGL_COMMAND_BUFFER_H__" does not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

@LukasBanana
Copy link
Owner

Thank's for the hint, I always used this identifier syntax in my projects and with the repsective Project name prefix (here "LLGL_") I never had a problem with that.
But I will fix this as soon as possible.

@oleid
Copy link

oleid commented Oct 25, 2016

How about using a "#pragma once" instead of a preprocessor guard?

@LukasBanana
Copy link
Owner

I know "#pragma once" is implemented in most C++ compilers, but since it's not part of the C++ standard, I'd like to use header guards instead.

@LukasBanana
Copy link
Owner

Renamed all header guards from "LLGL_..._H" to "LLGL_..._H".

@elfring
Copy link
Author

elfring commented Oct 27, 2016

Thanks for your improvement of affected identifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants