Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make StationData fields public #3

Closed
dbrgn opened this issue Aug 25, 2020 · 2 comments 路 Fixed by #4
Closed

Make StationData fields public #3

dbrgn opened this issue Aug 25, 2020 · 2 comments 路 Fixed by #4

Comments

@dbrgn
Copy link
Contributor

dbrgn commented Aug 25, 2020

Right now StationData only has private fields, which makes it pretty much useless 馃檪 Or am I missing something?
@dbrgn dbrgn mentioned this issue Aug 25, 2020
Merged
@lukaspustina
Copy link
Owner

Nope, you're not missing anything unless you just use this library to serialize the data structures with serde. Nevertheless, you're totally right, it really doesn't make sense.

I've just fixed the CI actions and updated the minimum Rust version to 1.38. I've also moved clippy and fmt to the stable channels using almost the default settings.

Please rebase you PR against master -- and be aware of the re-formatting. I'll accept the PR then.

@dbrgn
Copy link
Contributor Author

dbrgn commented Aug 25, 2020

+1 for rustfmt 馃檪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make station data public dbrgn/netatmo-rs
2 participants
@dbrgn @lukaspustina