-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
column filtering and generating columns not properly supported #42
Comments
Does this proposed interface consider "merged columns", i.e. vector columns? |
This should be solvable by extending open({ columns: [{
index: [0, 1, 2],
name: 'position',
type: DataType.Tuple,
types: [DataType.Number, DataType.Number, DataType.Number],
}]}); Similarly, the parser may pass an array of numbers to when proposing an auto-merge. In order to still access the original column names when rejecting the merge, the parser could pass the names of the original columns: // returned by open()
const merged = {
index: [0, 1, 2],
name: 'position',
type: DataType.Tuple,
names: ['x', 'y', 'z'],
types: [DataType.Number, DataType.Number, DataType.Number],
}});
// split back up
const columns: merged.names.map((n, i) => {
index: merged.index[i],
name: n,
type: merged.types[i],
}); These changes should intergrate nicely into the proposed interface. |
The current implementation does not allow filtering columns. On top of this, generated columns aren't working either, as the passed function can't be serialized for passing to a worker. To solve both issues, the following interface should be implemented:
The text was updated successfully, but these errors were encountered: