Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale share detection flags non-stale shares #5

Closed
luke-jr opened this issue Jul 15, 2012 · 2 comments
Closed

Stale share detection flags non-stale shares #5

luke-jr opened this issue Jul 15, 2012 · 2 comments
Assignees
Milestone

Comments

@luke-jr
Copy link
Owner

luke-jr commented Jul 15, 2012

Probably it is flagging all shares based on work before a longpoll, which are not necessarily stale.

I suggest 2 different "levels" of "staleness":

  1. the pool would rather we not work on this anymore
  2. the pool will reject results from this as stale

Obviously level 2 is pool-dependent, so perhaps some new flag on longpoll responses is needed to determine "are shares on old works now invalid" ("submitold" can and is used to try to keep stale rate graphs accurate, but shouldn't inhibit level 2 stales)

@luke-jr
Copy link
Owner Author

luke-jr commented Jul 24, 2012

OK, this looks uglier than I expected. There are already the 2 levels of staleness I proposed, but the logic for them is just totally wrong. Probably need to rewrite the stale_work function.

@luke-jr
Copy link
Owner Author

luke-jr commented Jul 29, 2012

Fixed in b69181f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant