Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to handling configuration #16

Closed
Luke-zhang-04 opened this issue Nov 13, 2021 · 0 comments · Fixed by #18
Closed

Changes to handling configuration #16

Luke-zhang-04 opened this issue Nov 13, 2021 · 0 comments · Fixed by #18
Labels
enhancement New feature or request

Comments

@Luke-zhang-04
Copy link
Owner

  • Use vscode.workspace.onDIdChangeConfiguration (or something of that sort) so the extension knows when the config has been changed
  • Don't throw on bad configuration value, just return the default
@Luke-zhang-04 Luke-zhang-04 added the enhancement New feature or request label Nov 13, 2021
@Luke-zhang-04 Luke-zhang-04 mentioned this issue Nov 13, 2021
Merged
@Luke-zhang-04 Luke-zhang-04 linked a pull request Nov 13, 2021 that will close this issue
feat(config): update configuration behaviour #18
Merged
Luke-zhang-04 added a commit that referenced this issue Nov 14, 2021
@Luke-zhang-04
feat(config): update configuration behaviour (#18)
6aa9373 
Features for #16 

- Use `vscode.workspace.onDidChangeConfiguration` (or something of that sort) so the extension knows when the config has been changed
- Don't throw on bad configuration value, just return the default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(config): update configuration behaviour Luke-zhang-04/processing-vscode
1 participant
@Luke-zhang-04