Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t8ch fixes #26

Merged
merged 2 commits into from Jul 31, 2020
Merged

t8ch fixes #26

merged 2 commits into from Jul 31, 2020

Conversation

t8ch
Copy link
Contributor

@t8ch t8ch commented Jul 3, 2020

No description provided.

@twiecki
Copy link
Contributor

twiecki commented Jul 27, 2020

Thanks @t8ch, was this throwing an error before?

@@ -72,7 +72,7 @@ def test_automatic_changepoints_2():

if __name__ == "__main__":
test_manning()
test_manning_reduced_six_months()
# test_manning_reduced_six_months() # TODO: add SMC sampling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you comment this out?

@t8ch
Copy link
Contributor Author

t8ch commented Jul 28, 2020

Hi.
Yes, I got

WARNING:root:Note that the automatic changepoint feature is experimental
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
~/projects-gitreps/pm-prophet/tests.py in 
----> 1 test_manning_reduced_six_months()

~/projects-gitreps/pm-prophet/tests.py in test_manning_reduced_six_months()
      10     m.add_seasonality(seasonality=7, fourier_order=3)
      11     m.add_seasonality(seasonality=30, fourier_order=3)
----> 12     m.fit(method=Sampler.SMC, draws=10000)
      13     m.predict(60, alpha=0.2, include_history=True, plot=True)
      14     m.plot_components(intercept=False)

~/miniconda3/envs/bayes/lib/python3.8/enum.py in __getattr__(cls, name)
    339             return cls._member_map_[name]
    340         except KeyError:
--> 341             raise AttributeError(name) from None
    342 
    343     def __getitem__(cls, name):

AttributeError: SMC

I think the SMC Sampler is simply not implemented yet.

@twiecki
Copy link
Contributor

twiecki commented Jul 28, 2020

@luke14free Are you still active on this project? Looking for help maintaining?

@luke14free
Copy link
Owner

I opened my own company and wish I had more free time to follow everything @twiecki 🙃 but @t8ch is trying to help me maintain the project. I'll look into active issues soon nevertheless

@t8ch
Copy link
Contributor Author

t8ch commented Jul 29, 2020

@twiecki do you think it makes already/still sense to migrate the code to pymc4 and implement changes and new features there?

@twiecki
Copy link
Contributor

twiecki commented Jul 29, 2020

No, not yet I think.

@luke14free How do you feel of moving this to its own org or the pymc3 org and giving access to some other people (like me) who can help maintaining?

@luke14free
Copy link
Owner

it makes 100% sense but I am not confident this library has the quality required to be in the pymc3 org. I am nevertheless happy to have you/tim take over/contribute.

@luke14free luke14free merged commit b108872 into luke14free:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants