Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle cacheable request types with the library #100

Closed
wants to merge 1 commit into from

Conversation

normano
Copy link

@normano normano commented Jun 8, 2020

I bundled @types/cacheable-request definition with the library primarily to solve the problem where dependent libraries (ex. got) fail to compile with @types/nodejs v13. This effectively removes dependency on @types/keyv (which is included in @types/cacheable-request) and bonus is that it would be much easier to update the definitions in the future should things change.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5dd4627 on normano:master into 0656a46 on lukechilds:master.

@normano
Copy link
Author

normano commented Jun 11, 2020

@lukechilds Did you need an issue filed for this?

@lukechilds
Copy link
Collaborator

lukechilds commented Jun 12, 2020

I'm not sure I understand the issue this is resolving.

I'm not a huge fan of TypeScript, this is a JavaScript project so ideally I would like to avoid committing TS related files to this repo.

If there is some sort of issue with DefinitelyTyped or Got resolving the @types package then it seems like it should be fixed on that end.

That said, this module was primarily written for use in Got, so if adding TS files to this repo is the only reasonable way to fix an issue then I'm definitely open to it.

@normano
Copy link
Author

normano commented Jun 12, 2020

"I'm not a huge fan of TypeScript, this is a JavaScript project so ideally I would like to avoid committing TS related files to this repo."

All I needed to know. That's fine. I'll maintain my own fork.

@normano normano closed this Jun 12, 2020
@lukechilds
Copy link
Collaborator

Just out of interest, why are you maintaining your own fork over using the @types package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants