Fix double prefix with TTL

[soundstep]

Entries set with a TTL are not deleted, the delete call is made with a double prefix which does not delete the entry.

Corresponding issue: #108

[coveralls]

Coverage remained the same at 100.0% when pulling f144622 on soundstep:fix-double-prefix into 57c03a4 on lukechilds:master.

[Kikobeats]

Hum, correct me if I'm wrong, the raw key need to be preserved in order definitely delete it at https://github.com/soundstep/keyv/blob/fix-double-prefix/src/index.js#L67, right?

BTW, @lukechilds can you take a look to this? 🙂

[soundstep]

@Kikobeats Yeah both are needed, the param key remains to be sent to the delete member function (the line you mentioned), which also does the prefixing (that was the doubling), and the keyPrefixed variable is used to get the entry from the store (as before there: https://github.com/soundstep/keyv/blob/fix-double-prefix/src/index.js#L57).

[soundstep]

As an aside, re-assigning a function param is not great, ideally a keyPrefixed should be created every time the _getKeyPrefix is called. That would make things clearer, for example in the set function.
But that's "style" so I haven't done that in the PR.

[lukechilds]

Thank you so much for this @soundstep, great spot!

[lukechilds]

As an aside, re-assigning a function param is not great, ideally a keyPrefixed should be created every time the _getKeyPrefix is called. That would make things clearer, for example in the set function.
But that's "style" so I haven't done that in the PR.

Can you explain a little bit more what you mean by this?

[lukechilds]

Ahh I get it, implemented in b879028

[lukechilds]

Published as keyv@4.0.1 🎉

[soundstep]

No problem @lukechilds !