-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix double prefix with TTL #107
Conversation
Hum, correct me if I'm wrong, the raw key need to be preserved in order definitely delete it at https://github.com/soundstep/keyv/blob/fix-double-prefix/src/index.js#L67, right? BTW, @lukechilds can you take a look to this? 🙂 |
@Kikobeats Yeah both are needed, the param |
As an aside, re-assigning a function param is not great, ideally a |
Thank you so much for this @soundstep, great spot! |
Can you explain a little bit more what you mean by this? |
Ahh I get it, implemented in b879028 |
Published as |
No problem @lukechilds ! |
Entries set with a TTL are not deleted, the
delete
call is made with a double prefix which does not delete the entry.Corresponding issue: #108