Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create effects within a reactivity root #37

Merged
merged 14 commits into from Mar 12, 2021
Merged

Create effects within a reactivity root #37

merged 14 commits into from Mar 12, 2021

Conversation

lukechu10
Copy link
Collaborator

@lukechu10 lukechu10 commented Mar 10, 2021 •
edited

Fixes #32

@lukechu10 lukechu10 added C-bug Category: bug, something isn't working A-reactivity Area: reactivity and state handling labels Mar 10, 2021
@lukechu10 lukechu10 marked this pull request as draft March 10, 2021 23:54
@vercel
Copy link

vercel bot commented Mar 11, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lukechu/maple/3nCNNjheis5xsiyonwqPskjVe7Jh
✅ Preview: https://maple-git-effect-root-lukechu.vercel.app

@vercel vercel bot temporarily deployed to Preview March 11, 2021 20:16 Inactive
@vercel vercel bot temporarily deployed to Preview March 11, 2021 22:43 Inactive
@lukechu10 lukechu10 mentioned this pull request Mar 11, 2021
Merged
@vercel vercel bot temporarily deployed to Preview March 11, 2021 23:14 Inactive
@lukechu10 lukechu10 marked this pull request as ready for review March 11, 2021 23:50
@vercel vercel bot temporarily deployed to Preview March 11, 2021 23:50 Inactive
@vercel vercel bot temporarily deployed to Preview March 11, 2021 23:55 Inactive
@vercel vercel bot temporarily deployed to Preview March 12, 2021 00:10 Inactive
@lukechu10 lukechu10 merged commit be748ed into master Mar 12, 2021
@lukechu10 lukechu10 deleted the effect-root branch March 12, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-reactivity Area: reactivity and state handling C-bug Category: bug, something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Properly dispose of effects
1 participant
@lukechu10