Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation misses directories and files #15

Closed
maxdevjs opened this issue Sep 1, 2018 · 7 comments
Closed

Installation misses directories and files #15

maxdevjs opened this issue Sep 1, 2018 · 7 comments

Comments

@maxdevjs
Copy link

maxdevjs commented Sep 1, 2018

npm init

✔ Which framework would you like to use? › React
✔ Select features needed for your project: › 
✔ Directory to use … .
✔ Are you sure you want to write into the current directory? … no
✔ OK. Please provide another directory. … test
(node:9360) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, scandir '~/.nvm/versions/node/v10.9.0/lib/node_modules/@pwa/cli/templates/assets'

Installation misses the following:

  • assets
  • css
  • index.html
  • .gitignore

(manually copying them solves the issue)

node -v 10.9.0
npm -v 6.4.1
@lukeed
Copy link
Owner

lukeed commented Sep 1, 2018

Hey, thanks! Are you on latest version of @pwa/cli? It should be 0.1.0

The current scaffolder is still incomplete, but what you selected should definitely be working.

@niccai
Copy link

niccai commented Sep 1, 2018

@lukeed Just hit the same issue as above, and yes to 0.1.0.

@lukeed
Copy link
Owner

lukeed commented Sep 1, 2018

Bummer! I'll jump on it in a few minutes. What were the selections?

@niccai
Copy link

niccai commented Sep 1, 2018

React > CSS preprocessor > current directory > y > y

This leads to an error

UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, scandir '/usr/local/lib/node_modules/@pwa/cli/templates/assets'
    at Object.fs.readdirSync (fs.js:904:18)
    at walk (/usr/local/lib/node_modules/@pwa/cli/node_modules/tiny-glob/sync.js:12:20)
    at module.exports (/usr/local/lib/node_modules/@pwa/cli/node_modules/tiny-glob/sync.js:62:3)
    at prompts.then.argv (/usr/local/lib/node_modules/@pwa/cli/lib/init.js:228:3)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

I noticed there is no assets folder in the installed @pwa/cli/templates - maybe your publish to npm is excluding a few things?

@lukeed
Copy link
Owner

lukeed commented Sep 1, 2018

Thanks! I'll just on this. Most definitely related to the last second TODO messages I added. ...that was a great idea..

@niccai
Copy link

niccai commented Sep 1, 2018

@lukeed Just quickly had a look...maybe files key in package.json under cli.

@lukeed
Copy link
Owner

lukeed commented Sep 1, 2018

Yupp..... that'll do it 🙈 Fixed in 0.1.1

Thank you both! 🙇

@lukeed lukeed closed this as completed Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants