Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development server always start on port 80 #20

Closed
kesonno opened this issue Sep 2, 2018 · 4 comments
Closed

Development server always start on port 80 #20

kesonno opened this issue Sep 2, 2018 · 4 comments
Labels
more info Additional information requested

Comments

@kesonno
Copy link

kesonno commented Sep 2, 2018

Hi,

maybe I'm missing something, but on my system, with a fresh installation, running watch always try to bind to localhost:80 (I see the debug message [PWA] Starting development server on http://localhost:80.

I tried with pwa watch --port 9090 and with this pwa.config.js in the root of the project:

  config.devServer.port = 9090;
};```

My current setup:

OSX 10.10.5
node v8.11.0
npm 5.6.0

Thanks in advance!

Gennaro
@mrbrannan
Copy link

I tried to reproduce this, thought it may be your node version. But I seem to have no issues on 8.11.x either.

image

image

I have the same results running pwa directly. The only difference I can tell is I am on macOS 10.13.6.

Also, the code defaults to 8080 for the server port, is this what you meant?

@lukeed
Copy link
Owner

lukeed commented Sep 2, 2018

Thanks! Ya I don't have any issues, same OS.

I think that you have a leaky ENV setting @kesonno. Try this instead:

PORT=9090 pwa watch

If that works, then you have a leftover PORT=80 from your previous session or in your PATH.

Thanks!

@lukeed lukeed added the more info Additional information requested label Sep 2, 2018
@kesonno
Copy link
Author

kesonno commented Sep 3, 2018

Thanks @mrbrannan for the check, and @lukeed you was right! I was working on a shell with a previously exported PORT env var, sorry to bother you :(

@kesonno kesonno closed this as completed Sep 3, 2018
@lukeed
Copy link
Owner

lukeed commented Sep 3, 2018

Not a bother, glad it was that simple!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more info Additional information requested
Projects
None yet
Development

No branches or pull requests

3 participants