Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch: --https flag overrides custom config #26

Closed
tuananh opened this issue Sep 4, 2018 · 4 comments
Closed

Watch: --https flag overrides custom config #26

tuananh opened this issue Sep 4, 2018 · 4 comments
Labels
bug Something isn't working

Comments

@tuananh
Copy link

tuananh commented Sep 4, 2018

i have this line in pwa.config.js

config.devServer.https = true

however, when i browse to https://localhost:8080 it shows ERR_SSL_PROTOCOL_ERROR

Do you have any idea why it happens? should i bring this to webpack devserver repo instead?

@lukeed
Copy link
Owner

lukeed commented Sep 4, 2018

Hey, this would be a WDS error, if anything. Although it sounds like your system is rejecting the certificate they're adding for you.

I'm sure they have docs/FAQ for that somewhere! You could also provide custom key and cert values, even if you just generate them quickly with openssl.

Closing as this isn't PWA related, but lemme know if you find the answer!

@lukeed lukeed closed this as completed Sep 4, 2018
@tuananh
Copy link
Author

tuananh commented Sep 4, 2018

i found pwa watch --https working for me.

@lukeed
Copy link
Owner

lukeed commented Sep 4, 2018

Oh, interesting. The --https flag does the same thing you did

@lukeed
Copy link
Owner

lukeed commented Sep 4, 2018

Ah, I think I see what's happening.

Thanks!

@lukeed lukeed reopened this Sep 4, 2018
@lukeed lukeed changed the title https in dev mode Watch: --https flag overrides custom config Sep 4, 2018
@lukeed lukeed added the bug Something isn't working label Sep 4, 2018
@lukeed lukeed closed this as completed in 3a0e7ac Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants