Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Installed brand new, not working straight up. #62

Closed
bovas85 opened this issue Jun 30, 2019 · 5 comments
Closed

React Installed brand new, not working straight up. #62

bovas85 opened this issue Jun 30, 2019 · 5 comments

Comments

@bovas85
Copy link

bovas85 commented Jun 30, 2019

Repro steps

  • Use windows.
  • Install globally
  • Create a project with offline plugin, React and eslint
  • yarn build

error:

[PWA] Deleted existing build directory
(node:9852) UnhandledPromiseRejectionWarning: Error: original.line and original.column are not numbers -- you probably meant to omit the original mapping entirely and only map the generated position. If so, pass null for the original mapping instead of an object with empty or null values.
    at SourceMapGenerator_validateMapping [as _validateMapping] (C:\xxx\checkout-new\node_modules\source-map\lib\source-map-generator.js:276:15)
@bovas85 bovas85 changed the title Installed brand new, not working straight up. React Installed brand new, not working straight up. Jun 30, 2019
@lukeed
Copy link
Owner

lukeed commented Jun 30, 2019

Node version?

@bovas85
Copy link
Author

bovas85 commented Jun 30, 2019

@lukeed I have v10.16.0

@lukeed
Copy link
Owner

lukeed commented Jun 30, 2019

Thanks, will boot Windows and check it out today.

@lukeed
Copy link
Owner

lukeed commented Jun 30, 2019

It's all builds currently. Does not happen during watch command, which means it's production-specific build.

This indeed is affecting everything globally. I created a new project 2 days ago and everything works, and now that's no longer the case. It had to be upstream issue, so I ran a diff on yarn.lock files and found that terser changed.

See relevant issue: terser/terser#380

Current workaround (using yarn) is to add the following inside package.json:

  "devDependencies": {
    // ...
  },
  "resolutions": {
    "terser": "4.0.0"
  }

@lukeed
Copy link
Owner

lukeed commented Jun 30, 2019

Closing because terser@4.0.2 was published, which reverts the offending commit.

Thanks!

@lukeed lukeed closed this as completed Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants