Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent recipe files with multiple auto-detected binaries #34

Closed
markhildreth opened this issue Dec 15, 2020 · 1 comment
Closed

Comments

@markhildreth
Copy link
Contributor

markhildreth commented Dec 15, 2020

I have noticed that in a scenario where auto binaries (binaries located in src/bin, but with no listing in the manifest) are read in using complete_from_path, the order in which the binaries are placed into the resulting manifest structure is not consistent. As a result, the cargo chef prepare may generate a few different versions of the recipe file with each call, even if nothing has changed, simply because of this inconsistent ordering.

Note that if the binaries are in the manifest file, rather than being auto-generated, things appear to be okay. That is the current workaround that I am using.

I've opened #33, which provides a potential fix and test case, although I'll admit both are a bit rough. Also, it only fixes auto binaries, I'm sure the same problem might exist with other auto-discovered targets that I'm not as familiar with.

@LukeMathWalker
Copy link
Owner

I merged #33 - thanks a lot for it!

The only other occasion where I think this issue might arise is at the intersection of auto-discovered binaries AND libraries - whether all [[bin]] sections are consistently added before or after the autodiscovered [lib] entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants