Added the ability to pass and receive arguments #97
Conversation
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 50.99% 49.51% -1.48%
==========================================
Files 3 3
Lines 202 208 +6
==========================================
Hits 103 103
- Misses 99 105 +6
Continue to review full report at Codecov.
|
|
I hope to merge this feature |
|
I will be reviewing it but I'm not sure this will make a release before 2.0 (where the feature is already built using a different approach). This is a breaking change and I'm not really willing to roll a 2.0 just for this. |
|
Ok, thanks for your reply. |
+1 |
Is there a branch for 2.0? I can only find |
|
I hope to merge this feature |
|
this seems quite critical, https://github.com/Flutterando/modular supports arguments pass. |
…a-master # Conflicts: # CHANGELOG.md # example/lib/components/demo/demo_simple_component.dart # example/lib/components/home/home_component.dart # example/lib/config/route_handlers.dart # example/lib/config/routes.dart # lib/src/router.dart # pubspec.yaml
fix conflicts
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 49.51% 49.51%
=======================================
Files 3 3
Lines 208 208
=======================================
Hits 103 103
Misses 105 105
Continue to review full report at Codecov.
|
…anschardt-master # Conflicts: # CHANGELOG.md # pubspec.yaml
fix dependOnInheritedWidgetOfExactType error
|
Hi! Thanks for the contribution. I took your idea and added custom RouteSettings to the latest release, so I'm closing this. Cheers! |
|
@lukepighetti Hm... you should have take more concern here. @ianko poured some hard work here. You could have simply just care more. It's been around more than a year |
Unfortunately I triaged the issues before the PRs, and in doing so I had already implemented RouteSettings based arguments by the time I triaged this. There is no doubt that a lot of care was put in this PR but it just didn't work out. Thanks for the thoughtful message. Since there is now considerable overlap in features between this PR and master, and we're only dealing with low hanging fruit so we can move on to implementing Fluro in Pages / Navigator 2.0, there is nothing actionable so I won't be reopening this PR. |
|
@softmarshmallow thanks for the consideration. I am fine with the solution. I am glad the feature is now available, it doesn't matter in which way. I am even happier to see this project moving once again and with plans for the 2.0. You can count on me @lukepighetti. |
Solves #46, #78 and #93.