Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itemModel Bind issues. #125

Closed
alvaroenoht opened this issue May 1, 2016 · 5 comments
Closed

itemModel Bind issues. #125

alvaroenoht opened this issue May 1, 2016 · 5 comments

Comments

@alvaroenoht
Copy link

In the last update 1.1.20 when using the model binding, the model wasnt loading in the constructor.
The reason was in LaraCart.php line 219,

I changed it to
$itemModel = $itemModel->with($this->itemModelRelations)->find($itemID);

and then line 238 taxable is expecting bool but Mysql wont return bool so I changed it to
$taxable = $itemModel[$bindings[\LukePOLO\LaraCart\CartItem::ITEM_TAXABLE]]?true:false;

@lukepolo
Copy link
Owner

lukepolo commented May 1, 2016

Can you make a PR changes seems solid enough

@lukepolo
Copy link
Owner

lukepolo commented May 1, 2016

Thank you for the insights on this !

@lukepolo
Copy link
Owner

lukepolo commented May 1, 2016

PR #126

@lukepolo lukepolo closed this as completed May 1, 2016
@lukepolo
Copy link
Owner

lukepolo commented May 1, 2016

c45166e

@alvaroenoht
Copy link
Author

No problem!. thank you for this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants