musescore@3.0.4.5763 URL change #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://ftp.osuosl.org/pub/musescore/releases/MuseScore-3.0.4/MuseScore-3.0.4.msi or https://ftp.osuosl.org/pub/musescore/releases/MuseScore-3.0.4/ do not exist. MuseScore release manager made the installers available at GitHub
shoogle
suggested changes
Mar 2, 2019
| @@ -3,7 +3,7 @@ | |||
| "homepage": "https://musescore.org/", | |||
| "version": "3.0.4.5763", | |||
| "license": "GPL-2.0-only", | |||
| "url": "https://ftp.osuosl.org/pub/musescore/releases/MuseScore-3.0.4/MuseScore-3.0.4.msi", | |||
| "url": "https://github.com/musescore/MuseScore/releases/download/v3.0.4/MuseScore-3.0.4-x86_64.msi", | |||
There was a problem hiding this comment.
Thanks for updating the URL, but this change will be lost the next time the manifest is updated. You need to make the corresponding change to the autoupdate URL further down the file. See App Manifest Autoupdate.
The autoupdate URL should be:
"autoupdate": {
"url": "https://github.com/musescore/MuseScore/releases/download/v$matchHead/MuseScore-$matchHead-x86_64.msi",There was a problem hiding this comment.
Thanks for making the change!
|
https://ftp.osuosl.org/pub/musescore/releases/MuseScore-3.0.4/ does exist (meanwhile) |
This was referenced Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ftp.osuosl.org/pub/musescore/releases/MuseScore-3.0.4/MuseScore-3.0.4.msi
or
https://ftp.osuosl.org/pub/musescore/releases/MuseScore-3.0.4/
do not exist. MuseScore release manager made the installers available at GitHub