Bump imagemagick and make #1192
Conversation
| @@ -19,7 +22,7 @@ | |||
| "conjure.exe", | |||
| "convert.exe", | |||
| "dcraw.exe", | |||
| "ffmpeg.exe", | |||
| ["ffmpeg.exe", "iffmpeg"], | |||
There was a problem hiding this comment.
The ffmpeg executable shipped with Imagemagick is rather dated. Aliasing the shim allows us to install the ffmpeg package alongside Imagemagick. Is there a better way?
There was a problem hiding this comment.
@rrelmy how does that sound to you? I will merge this since the current version is 404'ing, but please let us know or submit a pull request if there's a better way.
There was a problem hiding this comment.
I'm happy to undo it, if it's an issue. We could solve this in one of three ways:
- Add a "priority" flag to each app (or each exe), and assign a higher priority to ffmpeg. install/uninstall then needs to search all installed apps to see if any app supplies an exe. Ugh.
- When a new app installs/updates over a shim, ask the user which one s/he wants. Breaks the ffmpeg command, if the user selects the imagick version, but later uninstalls it. Yuk.
- Add ffmpeg's path to PATH before the shims path. Yuk, but doesn't break on uninstall.
There was a problem hiding this comment.
That's fine for me, I just was curious.
A fourth option would be removing this alias completely
There was a problem hiding this comment.
Another option would be to remove ffmpeg from imagick's bin list and add a "depends": ["ffmpeg"]. That's probably the best solution. Agreed?
There was a problem hiding this comment.
I did that change in #1197 ;-)
* fix autoupdate hash regression * update nodejs-lts 6.9.4 * add autoupdate.note * update mercurial 4.0.2 and add autoupdate * fix autoupdate if no arch specific options are set * update syncany-cli 0.4.7 and add autoupdate * update youtube-dl 2017.01.05 and add autoupdate * update git-lfs 1.5.4 and add autoupdate * fix far version number * update imagemagick 7.0.4-3 * replace imagemagick ffmpeg with dependency (as discussed in #1192) * update modd 0.4 and add autoupdate * whitelist chocolatey urls from HEAD check * update scriptcs 0.16.1 and add autoupdate * update rg 0.3.2 and add autoupdate * update kotlin 1.0.6 and add autoupdate * update xz 5.2.3 and add autoupdate * update openjdk 1.8.0.111-3 and add autoupdate * update git-up 1.4.1 and add autoupdate * update ninja 1.7.2 and add autoupdate
No description provided.